Create the default .tmux/resurrect dir if not exists#550
Open
jmbeach wants to merge 1 commit intotmux-plugins:masterfrom
Open
Create the default .tmux/resurrect dir if not exists#550jmbeach wants to merge 1 commit intotmux-plugins:masterfrom
jmbeach wants to merge 1 commit intotmux-plugins:masterfrom
Conversation
Small change to create the resurrect folder if it doesn't exist.
Without this, the resurrect folder might get created in a folder the
user doesn't expect. Ex: for me on my mac, the resurrect folder gets
created at: `.local/share/tmux/resurrect`, but I thought it would be at
`~/.tmux/resurrect`
I also got rid of the logic to fallback to `"${XDG_DATA_HOME:-$HOME/.local/share}"/tmux/resurrect`
if `default_resurrect_dir` doesn't exist since it would make the logic a
little more complicated to implement:
```diff
@@ -1,8 +1,4 @@
-if [ -d "$HOME/.tmux/resurrect" ]; then
- default_resurrect_dir="$HOME/.tmux/resurrect"
-else
- default_resurrect_dir="${XDG_DATA_HOME:-$HOME/.local/share}"/tmux/resurrect
-fi
+default_resurrect_dir="$HOME/.tmux/resurrect"
````
The problem is that the default folder only doesn't exist because it
hasn't ever been created.
I figure this isn't really an issue though since users can already
override the default by setting the `@resurrect-dir` setting.
jmbeach
commented
Aug 31, 2025
| resurrect_dir() { | ||
| if [ -z "$_RESURRECT_DIR" ]; then | ||
| local path="$(get_tmux_option "$resurrect_dir_option" "$default_resurrect_dir")" | ||
| local path |
Author
There was a problem hiding this comment.
Fixes shellcheck lint: Declare and assign separately to avoid masking return values (SC2155)
|
Oh well I had the same issue so I updated the docs instead at #554 to describe the current behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to create the resurrect folder if it doesn't exist.
Without this, the resurrect folder might get created in a folder the user doesn't expect. Ex: for me on my mac, the resurrect folder gets created at:
.local/share/tmux/resurrect, but I thought it would be at~/.tmux/resurrectI also got rid of the logic to fallback to
"${XDG_DATA_HOME:-$HOME/.local/share}"/tmux/resurrectifdefault_resurrect_dirdoesn't exist since it would make the logic a little more complicated to implement:The problem is that the default folder only doesn't exist because it hasn't ever been created.
I figure this isn't really an issue though since users can already override the default by setting the
@resurrect-dirsetting.