Remove manual variable expansion in resurrect-dir; use tmux formats instead.#560
Open
Gullumluvl wants to merge 1 commit intotmux-plugins:masterfrom
Open
Remove manual variable expansion in resurrect-dir; use tmux formats instead.#560Gullumluvl wants to merge 1 commit intotmux-plugins:masterfrom
Gullumluvl wants to merge 1 commit intotmux-plugins:masterfrom
Conversation
…instead. Updated the doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I noticed the original code was leaving backslashes in the save directory path. For instance, given a hostname of
servername.example.comand the following configuration line:the saved directory becomes
/home/myusername/.tmux/resurrect/\servername.example.com.This proposes to ditch this manual expansion, in favor of using native tmux formats (see updated docs).
The only special string that is substituted in this version is a leading tilde.
Since verbatim
$HOSTNAMEor$HOMEis no longer expanded, maybe a deprecation warning should be added.