Allow using an arbitrary program instead of urlview, with command-line args#32
Open
Boruch-Baum wants to merge 4 commits intotmux-plugins:masterfrom
Open
Allow using an arbitrary program instead of urlview, with command-line args#32Boruch-Baum wants to merge 4 commits intotmux-plugins:masterfrom
Boruch-Baum wants to merge 4 commits intotmux-plugins:masterfrom
Conversation
+ The reason I'm labeling this commit as 'strange' is that I found
this commit UNSTAGED the first time I viewed my local copy of the
repository! The git config declares the upstream as:
https://github.com/tmux-plugins/tmux-urlview
which of course does not have the commit. I have been using this
tmux environment for years and am only now examining the code, so
how did this commit get here? I certainly did not put it there.
+ This is upstream PR#23 from github user Erethon
+ Inspired by giuthub users laggardkernel, zethra
+ Extractor program can accept parameter arguments in its config
definition (eg. 'urlscan -R')
+ Needed to revert prior commit in order to support shell idiom %%
+ This should not have been the case, as sh does support %%. I
don't know why it always failed in my testing.
|
That's exactly what I was looking for! I need to use a custom "URL opener" and this is the best way to do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many people prefer
urlscantourlview, althoughurlscancan be agonizingly slow. The PR also sneaks in "better"(?) error messages.