Skip to content

Fixes #514 -- removing node when not using exclusive canonicalization fails validation #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varunrau wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #514 -- removing node when not using exclusive canonicalization fails validation #515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/libsaml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,6 @@ const libSaml = () => {

sig.loadSignature(signatureNode);

doc.removeChild(signatureNode);

verified = verified && sig.checkSignature(doc.toString());

// immediately throw error when any one of the signature is failed to get verified
Expand Down