Skip to content

samlcontent should be decrypted SAML response (sign then encrypt) #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mastermatt wants to merge 4 commits into
base: master
Choose a base branch
from
Open

samlcontent should be decrypted SAML response (sign then encrypt) #579

mastermatt wants to merge 4 commits into from

Conversation

@mastermatt
Copy link
Contributor

@mastermatt mastermatt commented Aug 28, 2025

This is a copy of the changes in #575, with the addition of test updates.

@mastermatt
Copy link
Contributor Author

mastermatt commented Aug 28, 2025

@tngan @ahacker1-securesaml I've updated tests for this small change.
I would really appreciate it if we could get this out as a patch.

@mastermatt mastermatt mentioned this pull request Aug 28, 2025
Closed
ahacker1-securesaml
ahacker1-securesaml approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@ahacker1-securesaml ahacker1-securesaml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. as a note, users should not use samlContent for any securit purposes or use it for authentication details. it should be used for purely debugging purposes

@ahacker1-securesaml
Copy link
Contributor

ahacker1-securesaml commented Aug 28, 2025

I am not the maintainer of this library. But I messaged him on slack to take a look.

You should look at sponsoring the library, https://github.com/sponsors/tngan
the maintainer has provided you a fast track to meet enterprise requirements. this library directly contributes to the companies security and revenue

ahacker1-securesaml referenced this pull request Oct 7, 2025
@ahacker1-securesaml
Refactor to support encrypted assertions (#571)
337a56e 
* Refactor to support encrypted assertions
- Update CHANGELOG.md

* Refactor: move authenio to devDependencies

* Upgrade xml-crypto to 6.1.2

* Fix: CHANGELOG.md
@mastermatt
Copy link
Contributor Author

mastermatt commented Nov 13, 2025

Hey @tngan could I bump you on this? I'm hoping to get a patch published. Let me know if I can help in anyway.

@ryanhos
Copy link

ryanhos commented Nov 13, 2025

@tngan I have some discretionary sponsorship funds available for a one-time contribution. Any chance you have time to get eyes on this soon?

@mastermatt
Merge branch 'master' into samlcontent-sign-then-encrypt
b439772 
# Conflicts:
#	test/flow.ts
@mastermatt
Call checkSignature is passed in arg
2c34a57 
Passing a value that was parsed and re-stringified can mess up whitespace encodings.
@mastermatt
Merge branch 'master' into samlcontent-sign-then-encrypt
4cfecad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ahacker1-securesaml ahacker1-securesaml ahacker1-securesaml approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mastermatt @ahacker1-securesaml @ryanhos