Confirm viewport cancellation and restore source focus - #460
Merged
Conversation
tninja
requested changes
Jul 27, 2026
tninja
left a comment
Owner
There was a problem hiding this comment.
Thanks for the contribution—this is a thoughtful improvement to viewport cancellation safety and source-focus restoration. I left one blocking lifecycle comment and one explicitly non-blocking defense-in-depth suggestion.
Contributor
Author
cxa
force-pushed
the
feat/viewport-cancel-confirmation
branch
from
July 27, 2026 16:19
4629ff4 to
00f59a0
Compare
Owner
|
Thank for the updates! Will review by the end of day. |
tninja
approved these changes
Jul 27, 2026
tninja
left a comment
Owner
There was a problem hiding this comment.
Thanks for addressing the feedback so thoroughly. The lifecycle guard and recursive-exit remaps close the data-loss path, and the updated coverage looks appropriate. Approved—thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
git diff --check