Skip to content

Conversation

@sweickge
Copy link
Contributor

@sweickge sweickge commented Jun 6, 2025

This MR should fix the netbox feature tests job failure in Netbox 4.3

Reasons for failures:

From Netbox 4.3 breaking changes website:

  1. The device and virtual_machine foreign keys on the Service model have been replaced with a generic parent relationship to support the assignment of services to FHRP groups as well.
  2. The group foreign key on the Contact model has been replaced with a many-to-many groups field.

For (1) Service model breakage:

  1. Updated the service.yaml initializer file. Instead of using just 'device' or 'virtual_machine' key, changed this to parent_type (model) and parent_name for specific one. This is similar to approach you took for vlan_groups

For example:

device: server01

updated to:

parent_type: dcim.device
parent_name: server01
  1. Updated the services.py model to support the changes

For (2) Contact model breakage:

  1. Updated contacts.yaml initializer file so group key was changed to a list with the groups key:
group: Network-Team

changed to:

groups:
   - Network-Team
  1. Updated contacts.py to support changes

Job run showing as passed now: https://github.com/sweickge/netbox-initializers/actions/runs/15498592051/job/43641109563

@mr1716
Copy link

mr1716 commented Jun 10, 2025

@sweickge so these changes will make the plugin able to work with 4.3.X?

@sweickge
Copy link
Contributor Author

sweickge commented Jun 10, 2025

@mr1716 It fixes the issues with the automated tests that are being run that are referenced in this discussion for why the plugins isn't working for 4.3. I imagine there might need to be some other work done afterwards by the maintainers to officially have it working for 4.3 (assuming they're ok with the proposed changes)

@mr1716
Copy link

mr1716 commented Jun 12, 2025

@sweickge thanks. Much appreciated! Would love to see this plugin work with 4.3

@sweickge
Copy link
Contributor Author

sweickge commented Jun 23, 2025

@tobiasge these latest changes should hopefully fix the failed other tests. I didn't realize i had to update versions in the other files

@sweickge
Copy link
Contributor Author

Sorry, one more push for the lint error...

@tobiasge tobiasge merged commit 7bf812f into tobiasge:main Jun 23, 2025
5 checks passed
@tobiasge
Copy link
Owner

@sweickge Thank you

@mr1716
Copy link

mr1716 commented Jun 23, 2025

Does this make the plugin ready for 4.3?

@sweickge
Copy link
Contributor Author

sweickge commented Jun 23, 2025

@tobiasge here are the breaking changes from the 4.3 release notes

netbox4 3-changes

I addressed number 4 and 5, so I would say yes, unless there is something else you see in this list that needs to be addressed in your plugin.

@mr1716
Copy link

mr1716 commented Jun 23, 2025

I’ll have to check it out later and let you know. But if it works for you, then it should work for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants