-
-
Notifications
You must be signed in to change notification settings - Fork 16
Fix netbox feature tests job failure in Netbox 4.3 #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n keys on the Service model have been replaced with a generic parent relationship to support the assignment of services to FHRP groups as well.
…een replaced with a many-to-many groups field.
|
@sweickge so these changes will make the plugin able to work with 4.3.X? |
|
@mr1716 It fixes the issues with the automated tests that are being run that are referenced in this discussion for why the plugins isn't working for 4.3. I imagine there might need to be some other work done afterwards by the maintainers to officially have it working for 4.3 (assuming they're ok with the proposed changes) |
|
@sweickge thanks. Much appreciated! Would love to see this plugin work with 4.3 |
|
@tobiasge these latest changes should hopefully fix the failed other tests. I didn't realize i had to update versions in the other files |
|
Sorry, one more push for the lint error... |
|
@sweickge Thank you |
|
Does this make the plugin ready for 4.3? |
|
@tobiasge here are the breaking changes from the 4.3 release notes I addressed number 4 and 5, so I would say yes, unless there is something else you see in this list that needs to be addressed in your plugin. |
|
I’ll have to check it out later and let you know. But if it works for you, then it should work for me |

This MR should fix the netbox feature tests job failure in Netbox 4.3
Reasons for failures:
From Netbox 4.3 breaking changes website:
For (1) Service model breakage:
parent_type(model) andparent_namefor specific one. This is similar to approach you took for vlan_groupsFor example:
updated to:
For (2) Contact model breakage:
groupskey:changed to:
Job run showing as passed now: https://github.com/sweickge/netbox-initializers/actions/runs/15498592051/job/43641109563