Fix custom field object type check #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a false-negative validation when applying
custom_field_datafrom YAML initializers.A custom field could be incorrectly reported as “not enabled for ”, even though it is enabled.
Root cause
ObjectType.objects.get_for_model()returns NetBox'sObjectType, whileCustomField.object_typesis a queryset of Django
ContentType(or a different type depending on NetBox version).Because the membership check compares different model classes,
ct not in cf.object_types.all()can evaluate to
Trueeven when the underlying content type matches.Changes
.filter(pk=ct.pk).exists()instead ofct in querysetReproduction
IPAM > Prefixcustom_field_datainprefixes.ymlload_initializer_dataBefore: prints “Custom field ... is not enabled for Prefix's model” and the value is not applied
After: no false warning and the custom field value is applied
Tested