Remove support for achievements #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested by @SkimnerPhi. If needed, mods should provide their own support for achievements. For vanilla this is dead code.
No longer used as achievements are gone. Also, avoid copying the old savegame dump object. This is possible thanks to this change.
dengr1065
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @SkimnerPhi. Vanilla is unlikely to ever provide any frontend for achievements (nobody cares about achievements), so this code would be unused. By removing stats stored in the savegame it is possible to remove savegame dump copying with minimal code changes - this can make saving faster in cases of large savegames and greatly reduce peak RAM usage.