Implement gzipped MessagePack savegame storage #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation for further changes. Savegames that are not compressed are much bigger, but this is a rather complex algorithm that shouldn't exist.
Make it slightly easier to replace the storage interface used for app_settings.bin and savegames.bin in case it's ever needed. Savegames always use app.storage for now, but this should be easier to change as well.
Keep track of the storage ID in each renderer Storage instance and pass it to the IPC bridge. Jobs are dispatched to the relevant handler (only saves/ for now) and all (de)compression is handled there. Add dedicated fs-job types to read or write and (de)compress data from/to the file picked by the user. Remove redundant utility functions that used web APIs instead.
Remove the CRC dependency and "binary file salt" in globalConfig.
Collaborator
Author
|
Merging this for better exposure. This is definitely a step in the right direction, issues can be solved if any are found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs some testing. The compression and decompression is definitely faster, but I'm not so sure about the UI performance - feels laggier? Perhaps that's because I'm comparing vanilla CE to upstream with Component Eagle installed. While a much bigger chunk of data is transferred through IPC now, it does not use an intermediate format - all slowdowns in this area have existed before with
JSON.stringifyand lz-string.Storage separation is partially done, the framework for adding mod-specific storages is there. Singular fs-job handler was reworked into small components, helper fs-job types were added to facilitate import and export of savegame and other files.
Closes #66.