Implement custom debounce for --watch force reload #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove chokidar built-in event debouncing/aggregating and replace it with a basic custom implementation with a 250ms settle delay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The options used for chokidar initialization were not enough to prevent double reloads, often causing both an instant reload and a 2s delayed one. With these changes there is no longer any debouncing on chokidar side and as we don't actually care about the specific file changed, this should work much better. This is mostly relevant for environments where the entire build folder is regenerated when bundling.
The only downside to this approach is a hardcoded settle time of 250ms, but it can be adjusted if needed or exposed as yet another command-line switch.