Unused/redundant code cleanup #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the canvas context loss handling as it was incorrect, simplify the error conditions in makeOffscreenBuffer and remove commented out code.
These files do not describe existing JS types and instead define their own. Usage of .d.ts extension prevents these types from being emitted when using emitDeclarationOnly, which affects generation of typings for mod development.
Remove the check of URL beginning with data:image. This is an old API, so leave other quirks as-is.
Remove globalConfig properties that are not used anywhere, simplify mobile device detection (mostly unused for normal builds) and merge or inline config constants where it makes sense.
Unlikely to be used and can be replicated with mods in a much better way.
Remove lastCanvas/lastContext cache for reusing canvas as creating a new canvas does not cause performance issue. Additionaly, remove smoothing classes and buffer registration as they are not used anywhere. Finally, remove redundant stageDestroyed calls in the InGameState.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some more code that is no longer used in the game and code that doesn't do anything useful. Things covered in this PR:
Content-Lengthheader (Electron sends the header)contextlossevent (it's ugly and cannot workaround the issue anyway)globalConfig,IS_DEBUGetc.