Skip to content

created a security scan for secrets #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Imambash6
Copy link

Used trufllehog to rrun a workflow check in the pipeline at the point of push to main branch and PR

@tobySolutions
Copy link
Owner

Feedback

Style

  • The diff is generally well-formatted and easy to read.
  • However, the new file .github/workflows.yml seems empty, which might be a mistake.

Security

  • A security scan using TruffleHog has been added, which is a good practice.
  • The continue-on-error: true flag in the TruffleHog step might allow vulnerabilities to go unnoticed if not properly monitored.

Performance

  • No significant performance-related changes are introduced in this diff.
  • The addition of a security scan might slightly increase build times.

Design

  • The introduction of a security scan is a good design choice, as it helps prevent secret leaks.
  • The update of lucide-react from 0.424.0 to 0.474.0 seems minor and unlikely to cause issues, but its necessity should be verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants