Skip to content

Fix client IP detection for IPv6 clients in forward auth #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elandrya2711 wants to merge 2 commits into
base: v3.3.4
Choose a base branch
from
+45 −3
Open

Fix client IP detection for IPv6 clients in forward auth #1264

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8959477
Fix client IP detection for IPv6 clients in forward auth
Elandrya2711 Aug 14, 2026
1315408
Add regression test for IPv6 client IP detection in forward auth
Elandrya2711 Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/mod/auth/sso/forward/util.go
View file
Open in desktop

@AnthonyMichaelTDM AnthonyMichaelTDM Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see a regression test for this behavior

Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,22 @@ func stringInSliceFold(needle string, haystack []string) bool {
}

func rSetIPHeader(r, req *http.Request, headers ...string) {
if r.RemoteAddr == "" || len(headers) == 0 {
if len(headers) == 0 {
return
}

before, _, _ := strings.Cut(r.RemoteAddr, ":")
host, _, err := net.SplitHostPort(r.RemoteAddr)
if err != nil {
host = r.RemoteAddr
}

ip := net.ParseIP(before)
ip := net.ParseIP(host)
if ip == nil {
// We should never leave a client supplied value in these headers when the address cannot be determined.
for _, header := range headers {
req.Header.Del(header)
}

return
}

Expand Down