Sync up master branch with v3.3.0 dev branch #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CHANGELOG.md
Optimize Github Action for creating the Docker image
Add tzdata and set the timezone in the Dockerfile.
Add tzdata package and timezone environment variable to Dockerfile
fix rc image release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the Docker setup and documentation, focusing on better timezone handling, workflow modernization, and general updates. The most significant changes are the addition of a configurable timezone environment variable, updates to the Docker build workflow for improved reliability and maintainability, and documentation enhancements to reflect these changes.
Docker and Timezone Improvements:
TZenvironment variable with a default ofEtc/UTCto the Dockerfile, allowing users to configure the container timezone easily. Also, includedtzdatain the image for timezone support. (docker/Dockerfile[1] [2]docker/README.mdto recommend setting theTZenvironment variable instead of mounting/etc/localtime, and documented the new variable in the environment variable table. (docker/README.md[1] [2] [3]CI/CD Workflow Enhancements:
.github/workflows/docker.ymlto use fixed action SHAs for improved security, centralized Docker configuration with environment variables, and streamlined tag handling for Docker image builds. The caching mechanism was also updated to use the Docker registry. (.github/workflows/docker.yml.github/workflows/docker.ymlR1-R61)Documentation and Changelog Updates:
CHANGELOG.md, summarizing new features, updates, and bug fixes. (CHANGELOG.mdCHANGELOG.mdR1-R10)