[System18] Changes requested by designer

[philcampeau]

Fixes #10456
Fixes #10459

Before clicking "Create"

• Branch is derived from the latest master
• Add the pins or archive_alpha_games label if this change will break existing games
• Code passes linter with docker compose exec rack rubocop -a
• Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Requested changes from designer:

• For both president sales and EMR issuing shares, the price moves down one space per block of shares sold/issued.
• Also, share issuing is done automatically in one block. It should not be allowed to sell shares in multiple blocks.

I made these changes. Additionally, I noted that there were two separate variables tracking if shared had been emergency issued: @emergency_issued and @emr_issue. I consolidated these together as @emergency_issued, as they didn't appear to be tracking different information.

I also removed this code below, since @emergency_issued is already being reset in the def setup method of that same step.

18xx/lib/engine/game/g_system18/step/buy_train.rb

Lines 37 to 40 in 29e21ad

	def process_buy_train(action)
	super
	@emr_issue = false
	end

Screenshots

Any Assumptions / Hacks

[ollybh]

The link needs to include the rkley parameter (from #10459). That lets you access the file without being signed into Dropbox.

Suggested change

	GAME_RULES_URL = 'https://www.dropbox.com/scl/fi/or38t89eczc5eki8e21y7/System18_Rules.pdf'
	GAME_RULES_URL = 'https://www.dropbox.com/scl/fi/or38t89eczc5eki8e21y7/System18_Rules.pdf?rlkey=n9kblkl7kvnz96oobs6hsatk2&dl=0'

[ollybh]

You're referencing both @emergency_issued and @round.emergency_issued in this file. These will be two different variables.

[ollybh]

issuable_bundles could contain share bundles for more than one corporation. I guess this is for an 1841-style game where corporations can own shares of other corporations, and these could be issued in emergency money raising.

This is going to return a single bundle for one corporation. It should return a single bundle for each corporation. So this bit needs to be moved into the @corporations.flat_map block.

I don't know if any currently implemented rules for System18 allow corporations to own other corporations' shares, but this has been written to allow this, so should be preserved.