-
Notifications
You must be signed in to change notification settings - Fork 198
[18PA] pre-alpha updates (tiles, tokens, bonus markers) #11718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollybh
requested changes
May 8, 2025
@ollybh I believe I've done all the changes suggested. |
ollybh
requested changes
Jun 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few very minor things to change.
ollybh
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before clicking "Create"
master
docker compose exec rack rubocop -a
docker compose exec rack rake
Implementation Notes
Explanation of Change
Implemented some basic additions to the code. Tiles, token logos, the Scranton bonus (borrowed from the VA Coalfields code in 1828, but modified to not restrict access to the hex).
Corrected float percentages. EBUY_DEPOT_TRAIN_MUST_BE_CHEAPEST,
Also implemented the dividend structure for the minors (pays half to owner, other half stays in the bank)
Still very much prealpha.
Screenshots
Any Assumptions / Hacks