Skip to content

[18PA] pre-alpha updates (tiles, tokens, bonus markers) #11718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2025

Conversation

philcampeau
Copy link
Collaborator

Before clicking "Create"

  • Branch is derived from the latest master
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Implemented some basic additions to the code. Tiles, token logos, the Scranton bonus (borrowed from the VA Coalfields code in 1828, but modified to not restrict access to the hex).

Corrected float percentages. EBUY_DEPOT_TRAIN_MUST_BE_CHEAPEST,

Also implemented the dividend structure for the minors (pays half to owner, other half stays in the bank)

Still very much prealpha.

Screenshots

Any Assumptions / Hacks

@ollybh ollybh added the new games Issues relating to games that are not yet alpha test level label May 8, 2025
@philcampeau
Copy link
Collaborator Author

@ollybh I believe I've done all the changes suggested.

Copy link
Collaborator

@ollybh ollybh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few very minor things to change.

@ollybh ollybh merged commit c365bc1 into tobymao:master Jun 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18PA new games Issues relating to games that are not yet alpha test level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants