[18PA] pre-alpha updates (tiles, tokens, bonus markers) #11718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollybh
added
the
new games
ollybh
requested changes
May 8, 2025
| return super if entity.corporation? && entity.type != :minor | ||
|
|
||
| amount = revenue / 2 | ||
| { corporation: 0, per_share: amount } |
There was a problem hiding this comment.
Doesn't half the money go to the minor?
Suggested change
| { corporation: 0, per_share: amount } | |
| { corporation: amount, per_share: amount } |
There was a problem hiding this comment.
No. Minors have no Treasury in 18PA:
| end | ||
|
|
||
| def share_price_change(entity, revenue = 0) | ||
| return {} if entity.minor? |
There was a problem hiding this comment.
Are there Minors in this game? As in, Minor objects, not corporations of type minor.
| module G18PA | ||
| module Step | ||
| class Track < Engine::Step::Base | ||
| include Engine::Game::G18PA::Tracker |
There was a problem hiding this comment.
You could override potential_tile_colors in this file, instead of having a separate Tracker file.
Comment on lines
+184
to
+185
| tile = hex_by_id(corporation.coordinates)&.tile | ||
| tile.cities[corporation.city || 0].place_token(corporation, corporation.tokens.first, free: true) unless tile.nil? |
There was a problem hiding this comment.
Could tile be nil? Isn't the game going to break if any corporation's home token can't be placed at this point?
| @@ -145,23 +143,86 @@ class Game < Game::Base | |||
| }, | |||
| ].freeze | |||
|
|
|||
| SCRANTON_HEX = 'G12' | |||
| SCRANTON_MARKER_ICON = 'coal' | |||
There was a problem hiding this comment.
The map changes below have mine, not coal icons.
Suggested change
| SCRANTON_MARKER_ICON = 'coal' | |
| SCRANTON_MARKER_ICON = 'mine' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before clicking "Create"
masterdocker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
Implemented some basic additions to the code. Tiles, token logos, the Scranton bonus (borrowed from the VA Coalfields code in 1828, but modified to not restrict access to the hex).
Corrected float percentages. EBUY_DEPOT_TRAIN_MUST_BE_CHEAPEST,
Also implemented the dividend structure for the minors (pays half to owner, other half stays in the bank)
Still very much prealpha.
Screenshots
Any Assumptions / Hacks