fix(bigquery): Do not generate null ordering on agg funcs #4172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4170
BigQuery does not allow
ASC NULLS LAST
andDESC NULLS FIRST
ordering in aggregate functions:Note that BigQuery is the only dialect with
NULL_ORDERING_SUPPORTED = False
so this PR uses this as a proxy to handle this case.