Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Unexpected row deduplication using eliminate_full_outer_join #4178

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Fix: Unexpected row deduplication using eliminate_full_outer_join #4178

merged 7 commits into from
Oct 3, 2024

Commits on Sep 30, 2024

  1. Fix: changed the union logic to consist of a left join + an anti join… 

    … with union all.

This should be more in line with the behaviour of FULL OUTER JOIN since it keeps duplicate rows that would be generated when the joined table has many entries for the same key(s).
https://en.wikipedia.org/wiki/Join_%28SQL%29#Full_outer_join
    @liaco
    liaco committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8cd77cd View commit details
    Browse the repository at this point in the history

  2. Fix: order by clauses, table alias and tests

    @liaco
    liaco committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3eb3f23 View commit details
    Browse the repository at this point in the history

  3. Fix: comments

    @liaco
    liaco committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8431bd4 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. PR feedback 1

    @liaco
    liaco committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    009a6cf View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. PR Feedback 2

    @liaco
    liaco committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0b1b86c View commit details
    Browse the repository at this point in the history

  2. Added test case for USING with multiple columns

    @liaco
    liaco committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0e900d9 View commit details
    Browse the repository at this point in the history

  3. Cleaned up test cases

    @liaco
    liaco committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    db16444 View commit details
    Browse the repository at this point in the history