Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: properly escape closing identifier delimiters #4202

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

georgesittas
Copy link
Collaborator

Only related SO thread I found is this one, but I played using T-SQL and concluded that [ after the opening bracket doesn't need to be escaped, but ] does because it needs to be disambiguated from the closing delimiter:

1> SELECT 1 AS [[x]]], 1 AS "[y]"
2> GO
[x]         [y]        
----------- -----------
          1           1

@georgesittas georgesittas merged commit f935e42 into main Oct 2, 2024
6 checks passed
@georgesittas georgesittas deleted the jo/fix_identifier_end_escaping branch October 2, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants