Lr1110 quickfixes #504
Open
Lr1110 quickfixes #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brghena
reviewed
May 14, 2025
| @@ -57,7 +59,7 @@ void hal_hex_to_bin( char *input, uint8_t *dst, int len ) | |||
| { | |||
| char tmp[3]; | |||
| uint16_t length = strlen( input ); | |||
| tmp[2] = NULL; | |||
| tmp[2] = '\0'; | |||
There was a problem hiding this comment.
Big fan of this change. I frequently tell my students 0, False, '\0', and NULL are separate things and should be used in semantically meaningful ways. /rant
There was a problem hiding this comment.
Well, turn on -std=c23 and on newer compilers it seems to be a hard error by default :)
brghena
requested changes
May 14, 2025
ppannuto
force-pushed
the
lr1110-quickfixes
branch
2 times, most recently
from
fd00714 to
2d393ce
Compare
ppannuto
force-pushed
the
lr1110-quickfixes
branch
from
2d393ce to
1c01239
Compare
bradjc
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #502, the (newer than CI) compiler (on my machine) is a bit stricter / catches some things that result in hard errors.
These fixup the missing includes and other small warnings that were now promoted to errors.
The switch away from
unzip + mv + rmdiris to (1) simplify, and (2) handle hidden directories correctly (since there is now a.github/folder in the upstream root).