Add Multi-Board Treadmill Descriptors & BLE Advertise+Scan Test #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
board descriptors init board_descriptors no serial init board descriptor cluser board board_descriptors: update board_module paths board_descriptors: add nrf serial numbers and new methods for erase_board multi_board: remove target_spec.yaml and read directly from board descriptor files multi_board: remove leading zeroes from serial numbers multi_board: revert changes to kernel board path multi_board: adapter serial command replaces hle_serial multi_board: override tocloader general flags multi_board: openocd options with jlink serial no "multi_board config: using new --openocd-serial-number" multi_board config: Removed the --openocd flag from our TOCKLOADER_GENERAL_FLAGS since it's already added by the Makefile" use tockloader directly rather than make flash openocd update board path for flash openocd command overwrite flash app with new adapter serial properly select unique serial ports for each board based on its serial number: Sort the matching ports by device name Allow the board to be created with a default port initially multi_board: change board path for --openocd-board multi_board: use correct openocd board path multi_board: temporary fix for rustup 1.28.0 test is properly validating the communication between the two boards Multi-Board Treadmill Descriptors & BLE Advertise+Scan Test
charles37
force-pushed
the
dev/mult-board-treadmill
branch
from
7b9d0e1 to
7af45c3
Compare
…ck-hardware-ci into dev/mult-board-treadmill
lschuermann
reviewed
Apr 2, 2025
Comment on lines
+44
to
+56
| # New inputs for multi-board tests | ||
| multi-board: | ||
| required: false | ||
| type: string | ||
| default: 'false' | ||
| supervisor-id: | ||
| required: false | ||
| type: string | ||
| default: '' | ||
| board-descriptors: | ||
| required: false | ||
| type: string | ||
| default: '' |
There was a problem hiding this comment.
Can we add descriptions on what these inputs are for, and their expected format?
| @@ -1,6 +1,10 @@ | |||
| model: nrf52840dk | |||
| hw_rev: '3.2' | |||
| serial_number: 0xfoobar | |||
| serial_number: '0679be07-6106-48aa-8057-b1d4f2e18a99' | |||
There was a problem hiding this comment.
I don't think serial_number is a good label here. This is just the host ID, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Title:
Add Multi-Board Treadmill Descriptors & BLE Advertise+Scan Test
Pull Request Description:
--board-descriptorsinstead of--boards.main.py: Dynamically import board modules listed in YAML (e.g.board-nrf52840dk-<serial>.yml).ble_advertising_scanning_test.pyto verify advertiser and scanner boards can detect each other.With these changes,
tock-hardware-cican run multi-board tests using Treadmill descriptors