Skip to content

Fix default ruleset link #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

wesley-dean
Copy link

@wesley-dean wesley-dean commented Apr 4, 2025

Motivation

@Sundhar22 pointed out in #331 that the link in the GitHub Page view of the site is not working.

Proposed Changes

Change the link URL from relative (which works when viewed through the repo but not the Page) to an absolute URL (which works correctly in both locations).

Test Plan

@wesley-dean wesley-dean requested a review from hyandell as a code owner April 4, 2025 17:36
@wesley-dean
Copy link
Author

before change:
Screenshot_20250404_133654

after change:

Screenshot_20250404_133545

@wesley-dean
Copy link
Author

Also, I added a link labeled raw so that a user can get at the ruleset file directly (e.g., via curl or wget)

@wesley-dean
Copy link
Author

closes #331

@wesley-dean wesley-dean mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant