Add sandesh ,sudip #165
Merged
Add sandesh ,sudip #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roshni73
requested review from
kopitek8 and
AdityaKhatri
and removed request for
kopitek8
roshni73
force-pushed
the
fix/add-employee
branch
from
8962e63 to
5b8bae4
Compare
roshni73
force-pushed
the
fix/add-employee
branch
from
5b8bae4 to
300b088
Compare
kopitek8
reviewed
Apr 2, 2025
src/data/employees.ts
Outdated
| @@ -128,7 +129,7 @@ const udayMaharjan: Employee = { | |||
| name: 'Uday Maharjan', | |||
| position: 'Assistant Project Manager', | |||
| funnyDescription: 'What is your school\'s name? School Maharjan', | |||
| description: 'Meet Uday, a 27-year-old man who is still trying to figure out what he wants to be when he grows up (because let\'s be real, at 26 you\'re basically a grown-up, right?). Despite his indecisiveness, Uday is a pretty cool dude. He\'s always up for a good time, whether it\'s cracking jokes with his friends or trying out a new restaurant in town. Uday is also an avid Liverpool FC fan, and can often be found cheering on his favorite team on game day.When he\'s not rooting for the home team, you might catch him going on hikes with his buddies or going on bike rides. In his spare time, Uday enjoys partying, playing video games, collecting KinderJoy toys and listening to music.He\'s also been known to dance every now and then (just don\'t ask him to dance). Overall, Uday is a fun- loving, easy-going guy who is always up for an adventure.', | |||
| description: 'Meet Uday, a 28-year-old man who is still trying to figure out what he wants to be when he grows up (because let\'s be real, at 26 you\'re basically a grown-up, right?). Despite his indecisiveness, Uday is a pretty cool dude. He\'s always up for a good time, whether it\'s cracking jokes with his friends or trying out a new restaurant in town. Uday is also an avid Liverpool FC fan, and can often be found cheering on his favorite team on game day.When he\'s not rooting for the home team, you might catch him going on hikes with his buddies or going on bike rides. In his spare time, Uday enjoys partying, playing video games, collecting KinderJoy toys and listening to music.He\'s also been known to dance every now and then (just don\'t ask him to dance). Overall, Uday is a fun- loving, easy-going guy who is always up for an adventure.', | |||
There was a problem hiding this comment.
Can you please update 26 to 28 below as well? haha
src/data/employees.ts
Outdated
| @@ -45,7 +45,8 @@ export type EmployeeId = 'tc-001' | |||
| | 'tc-072' | |||
| | 'tc-073' | |||
| | 'tc-074' | |||
| | 'tc-075'; | |||
| | 'tc-075' | |||
There was a problem hiding this comment.
Can you confirm with Bimal Saud about Sandesh and Sudip's ID card ID? tc-id needs to match the ID of the ID card.
src/resources/employee/roshani.png
Outdated
There was a problem hiding this comment.
We will need to scale this image to match others' format
src/resources/employee/sudip.png
Outdated
There was a problem hiding this comment.
We will need to scale this image to match others' format
src/resources/employee/uday.png
Outdated
There was a problem hiding this comment.
We will need to scale this image to match others' format
roshni73
force-pushed
the
fix/add-employee
branch
from
300b088 to
353d6f4
Compare
kopitek8
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sudip and sudip