Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-tooltip-zero-value.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tokens-studio/figma-plugin": patch
---

Fix token tooltip not displaying resolved value when value is 0
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default function AliasBadge({ value }: Props) {

return (
<StyledAliasBadge>
{formatTokenValueForDisplay(value || '', currentBaseFontSize)}
{formatTokenValueForDisplay(value ?? '', currentBaseFontSize)}
</StyledAliasBadge>
);
}
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,20 @@ const tokens: SingleToken[] = [
description: 'a broken reference',
failedToResolve: true,
},
{
name: 'spacing.none',
type: TokenTypes.SPACING,
value: 0,
rawValue: 0,
description: 'zero value token',
},
{
name: 'spacing.alias',
type: TokenTypes.SPACING,
value: 0,
rawValue: '{spacing.none}',
description: 'alias to zero value token',
},
{
name: 'border.regular',
type: TokenTypes.BORDER,
Expand Down Expand Up @@ -420,4 +434,52 @@ describe('TokenTooltip alias', () => {
expect(getByText(String('brokentoken'))).toBeInTheDocument();
expect(getByTestId('not-found-badge')).toBeInTheDocument();
});

it('displays resolved value of 0 correctly', () => {
const { getByText } = render(
<TokensContext.Provider value={customStore}>
<TokenTooltipContent
token={{
name: 'spacing.alias',
type: TokenTypes.SPACING,
value: '{spacing.none}',
rawValue: '{spacing.none}',
description: 'alias to zero value token',
}}
/>
</TokensContext.Provider>,
);

expect(getByText('0')).toBeInTheDocument();
});

it('displays zero values in composition token tooltip', () => {
const compositionZeroToken = {
name: 'card.zero',
type: TokenTypes.COMPOSITION,
value: {
spacing: 0,
borderRadius: 0,
},
rawValue: {
spacing: 0,
borderRadius: 0,
},
description: 'composition token with zero values',
} as SingleToken;

const store = {
resolvedTokens: [compositionZeroToken],
};

const { getAllByText, getByText } = render(
<TokensContext.Provider value={store}>
<TokenTooltipContent token={compositionZeroToken} />
</TokensContext.Provider>,
);

expect(getByText('spacing')).toBeInTheDocument();
expect(getByText('borderRadius')).toBeInTheDocument();
expect(getAllByText('0').length).toBeGreaterThanOrEqual(2);
});
});
Loading