Remove .close(), and document clean WebSocket closing
#2974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Oct 10, 2024
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Thanks! Got a few questions / suggestions about the new docs.
Co-authored-by: Jonas Platte <[email protected]>
jplatte
reviewed
Oct 11, 2024
Contributor
Author
|
Ah. I capitalied “axum” based on other examples in the repo of it beïng capitalized. They should probably be removed, I guess. |
jplatte
approved these changes
Oct 11, 2024
Member
|
Yeah, it should. In the readme it's consistently lowercase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current
.close()method is mostly useless, because it does not allow sending a close frame and takes ownership of the WebSocket, which even forbids implementing the normal WebSocket close handshake.Solution
Remove
.close(), and document the behaviour of WebSocket close handshakes.Closes: #2964