Skip to content

Conversation

@jplatte
Copy link
Member

@jplatte jplatte commented Dec 10, 2024

Closes #3060.

@yanns @mladedav I'd love to do another call for testing with all these changes in. @mladedav do you think you're gonna spend some time on the percent-encoded routing thing (not as in code, but as in getting back to the discussion)? Or should we ship without it?

@jplatte jplatte requested review from mladedav and yanns December 10, 2024 03:06
Copy link
Collaborator

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of users will look at the changelog from axum, and will miss the ones in axum-core.
I'd suggest to copy/paste the core change log into axum. WDYT?

@yanns
Copy link
Collaborator

yanns commented Dec 17, 2024

@jplatte What do you think about copy / pasting the change log? Alternatively, we could provide a link from axum to axum-core change log. But I think that the copy / paste is easier for our users.

@jplatte
Copy link
Member Author

jplatte commented Dec 17, 2024

Sorry, been pretty busy. I think I'll add a link. Either way I agree that it would be good to have those entries easier to discover.

@jplatte
Copy link
Member Author

jplatte commented Dec 17, 2024

I've added a note with a link. For the GH release I'll adjust it to point to the right release page.

@jplatte jplatte requested a review from yanns December 17, 2024 22:42
@jplatte jplatte merged commit 5cdd8a4 into main Dec 17, 2024
18 checks passed
@jplatte jplatte deleted the jplatte/tcp-nodelay-changelog branch December 17, 2024 22:47
@yanns
Copy link
Collaborator

yanns commented Dec 18, 2024

I did the same for https://github.com/tokio-rs/axum/releases/tag/axum-v0.8.0-alpha.1

@mladedav
Copy link
Collaborator

Sorry, I was (and still am) a bit busier than usual. I'll definitely get back to the percent encoding, but I think we can ship the manor version without it.

@jplatte
Copy link
Member Author

jplatte commented Dec 18, 2024

I figured as much and moved the percent encoding thing to the 0.9.0 milestone. But maybe that's the wrong place too? I guess it might not even be that clear whether it's going to be breaking.

Anyways, I've added two more things to the 0.8.0 milestone that should probably be done before the release, will spend some time on them over the holidays and probably release around the new year if no new blockers come up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tcp_nodelay removal to changelog

3 participants