Release axum 0.8.6 and related crates #3507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The failures should be the same as #3501 First time I've seen this when creating a PR, I guess it's one of those days when everything breaks. |
Member
|
I'm surprised CI ran at all given there are merge conflicts. Instead of making a PR from the v0.8.x branch directly, can you make a new branch with a merge commit and open a PR for that? As in git switch main
git switch -c mladedav/v0.8.6
git merge v0.8.x
# fix merge conflicts and commit |
Collaborator
Author
|
Right. Sorry about that. |
Member
|
No worries. It's not the most obvious workflow, but I like it because it ensures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is practically empty release just to fix docs.rs build.