Make it easier to visually scan for default features #3550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tables with yes–no columns (or other kinds of binary distinctions) can be difficult to 👀 visually scan if the column in each row contains “yes” or “no”. It’s usually easier to spot the “yes” rows if they have a symbol there that the “no” rows do not.
The tables of available features on
axumandaxum-extrahave this issue on their Default? column where thedefaultfeatures are indicated.Solution
This PR removes the “No” values, and replaces “Yes” with a checkmark. Scaled down here to fit within the PR description space, the easier readability is (imo!) even more obvious.
For screen readers, I wrapped the checkmark in a
<span>which sets thearia-labelto “Default feature”, so this should be clearer even when the table is not being visually read.I appreciate everyone who’s worked to ship and maintain such a delightful library as Axum! 🙏🏻