Skip to content

impl Sync for RouterIntoService #3552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

impl Sync for RouterIntoService #3552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions axum/src/routing/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,11 @@ pub struct RouterIntoService<B, S = ()> {
_marker: PhantomData<B>,
}

// SAFETY: B is only held onto as PhantomData so does not affect the Sync-ness of
// RouterIntoService; S passed deep into the type heirarchy but eventually ends up as part of
// Box<dyn ErasedIntoRoute<S, E>> and ErasedIntoRoute<S, E> as Send + Sync supertrait bounds.
unsafe impl<B, S> Sync for RouterIntoService<B, S> {}

impl<B, S> Clone for RouterIntoService<B, S>
where
Router<S>: Clone,
Expand Down
Loading