Allow latest version of matchit (v0.8.6) #3568
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I believe there's already 0.9 out though. Also note that the prefix/sufix rules have been reworked between that and the last 0.8.x release so it's better to skip that. |
Collaborator
|
You might also take a look at #3143. Just the fact that current tests pass isn't sufficient because axum has to handle the new matchit features introduced in the new version. |
Author
|
Ah, I didn't see that #3143 was already in the works. I'll close this one. Thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the version constraint on
matchitto include the latest v0.8.6 release, bringing in the latest improvements and fixes from the routing library. I've verified that all tests still pass on the latest version.