Skip to content

refac(axum-extra): improve test invariants for protobuf.rs extractor #3569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 23, 2025
Merged

refac(axum-extra): improve test invariants for protobuf.rs extractor #3569

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
646daba
refac: improve test invariants for protobuf.rs extractor
darth-raijin Nov 23, 2025
23c1754
remove unused import
darth-raijin Nov 23, 2025
e621901
cargo fmt changes
darth-raijin Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions axum-extra/src/protobuf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ mod tests {
use super::*;
use crate::test_helpers::*;
use axum::{routing::post, Router};
use http::header::CONTENT_TYPE;
use http::StatusCode;

#[tokio::test]
async fn decode_body() {
Expand All @@ -182,9 +184,11 @@ mod tests {
let client = TestClient::new(app);
let res = client.post("/").body(input.encode_to_vec()).await;

let status = res.status();
let body = res.text().await;

assert_eq!(body, "bar");
assert_eq!(status, StatusCode::OK);
assert_eq!(body, input.foo);
}

#[tokio::test]
Expand All @@ -211,6 +215,7 @@ mod tests {
let res = client.post("/").body(input.encode_to_vec()).await;

assert_eq!(res.status(), StatusCode::UNPROCESSABLE_ENTITY);
assert!(res.text().await.starts_with("Failed to decode the body"));
}

#[tokio::test]
Expand Down Expand Up @@ -243,15 +248,20 @@ mod tests {
let client = TestClient::new(app);
let res = client.post("/").body(input.encode_to_vec()).await;

let content_type_header_value = res
.headers()
.get(CONTENT_TYPE)
.expect("missing expected header");

assert_eq!(
res.headers()["content-type"],
content_type_header_value,
mime::APPLICATION_OCTET_STREAM.as_ref()
);

let body = res.bytes().await;

let output = Output::decode(body).unwrap();

assert_eq!(output.result, "bar");
assert_eq!(output.result, input.foo);
}
}
Loading