fix: sse event do not skip data field when empty #3571
+7
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since https://github.com/tokio-rs/axum/releases/tag/axum-v0.8.5 SSE events with empty data are sent without a
datafield.Before :
After
According to https://html.spec.whatwg.org/multipage/server-sent-events.html (I did not found an RFC)
Which means these events are ignored (if I understand it correctly).
Before this change the SSE client I use was receiving the event, it does not anymore.
More context : jpopesculian/eventsource-stream#6
Solution
Write empty data field if set to an empty string as before.