Skip to content

fix: TypedPath conflicts with OptionalFromRequestParts #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jplatte merged 4 commits into from
Feb 9, 2026
+5 −1
Merged

fix: TypedPath conflicts with OptionalFromRequestParts #3645

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a39a4fc
fix: call FromRequestParts impl for Path to avoid conflict with Optio…
azureqaq Feb 4, 2026
7fe7221
add changelog for #3645
azureqaq Feb 6, 2026
01aba14
Apply suggestions from code review
jplatte Feb 6, 2026
693258e
Merge branch 'main' into main
tottoto Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions axum-macros/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- **breaking:** `#[from_request(via(Extractor))]` now uses the extractor's
rejection type instead of `axum::response::Response` ([#3261])
- **fixed:** Fix compilation error when deriving `TypedPath` with
`OptionalFromRequestParts` being in scope" ([#3645])

[#3261]: https://github.com/tokio-rs/axum/pull/3261
[#3645]: https://github.com/tokio-rs/axum/pull/3645

# 0.5.0

Expand Down
3 changes: 2 additions & 1 deletion axum-macros/src/typed_path.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ fn expand_named_fields(
parts: &mut ::axum::http::request::Parts,
state: &S,
) -> ::std::result::Result<Self, Self::Rejection> {
::axum::extract::Path::from_request_parts(parts, state)
<::axum::extract::Path<#ident> as ::axum::extract::FromRequestParts<S>>
::from_request_parts(parts, state)
.await
.map(|path| path.0)
#map_err_rejection
Expand Down