Skip to content

Conversation

@opara-tor
Copy link

@opara-tor opara-tor commented Nov 10, 2025

The backlog size logic that was copied from the standard library was for unix sockets, not inet sockets. Mio's backlog sizes differ greatly from the standard library for inet sockets (128 or smaller). The comments here were confusing/misleading, so I've tried to clarify them.

@Thomasdezeeuw
Copy link
Collaborator

Thomasdezeeuw commented Nov 13, 2025

Reading https://github.com/rust-lang/rust/blob/4f808ba6bf9f1c8dde30d009e73386d984491587/library/std/src/sys/net/connection/socket.rs#L538-L541 now, these values might be wrong. Might have to revert #1896 or split TCP from Unix values.

@opara-tor
Copy link
Author

I think having separate TCP and unix backlogs would be best. For TCP, I think sticking with the old value of 1024 makes sense to avoid breaking existing users, but maybe the special cases for horizon and haiku could be added.

Should I close this and open an issue instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants