-
Notifications
You must be signed in to change notification settings - Fork 33
Update README and crate documentations #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit makes the following documentation changes:
- Add missing metrics to README.md.
- Remove non-existent metrics from README.md.
- Re-order metrics in README.md and Rust code so that the order
matches between the two. This makes the docs easier to maintain and
read.
- Add missing links to README.md.
- Split runtime metrics into stable and unstable subsections in
README.md.
- Remove duplicate stable runtime base metrics section from README.md.
- Add metrics.rs task metrics integration docs to README.md.
- Add metrics.rs task metrics integration docs to crate docs in
lib.rs.
|
@arielb1 FYI, no rush, just wanted to make sure this didn't fall through the cracks since I opened it during the holidays. |
jlizen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping - and thank you for the cleanup!!
Let me know if you do want to take another pass based on my comments. I'm also happy to merge it as-is, just give me the go-ahead :)
I'll take another pass, thanks for the review! |
3837805 to
208f168
Compare
|
Thanks for the contribution |
This commit makes the following documentation changes: