Skip to content

Conversation

@jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Dec 20, 2025

This commit makes the following documentation changes:

  • Add missing metrics to README.md.
  • Remove non-existent metrics from README.md.
  • Re-order metrics in README.md and Rust code so that the order matches between the two. This makes the docs easier to maintain and read.
  • Add missing links to README.md.
  • Split runtime metrics into stable and unstable subsections in README.md.
  • Remove duplicate stable runtime base metrics section from README.md.
  • Add metrics.rs task metrics integration docs to README.md.
  • Add metrics.rs task metrics integration docs to crate docs in lib.rs.

This commit makes the following documentation changes:

  - Add missing metrics to README.md.
  - Remove non-existent metrics from README.md.
  - Re-order metrics in README.md and Rust code so that the order
    matches between the two. This makes the docs easier to maintain and
    read.
  - Add missing links to README.md.
  - Split runtime metrics into stable and unstable subsections in
    README.md.
  - Remove duplicate stable runtime base metrics section from README.md.
  - Add metrics.rs task metrics integration docs to README.md.
  - Add metrics.rs task metrics integration docs to crate docs in
    lib.rs.
@jkosh44 jkosh44 marked this pull request as ready for review December 20, 2025 20:55
@jkosh44
Copy link
Contributor Author

jkosh44 commented Jan 8, 2026

@arielb1 FYI, no rush, just wanted to make sure this didn't fall through the cracks since I opened it during the holidays.

Copy link
Member

@jlizen jlizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping - and thank you for the cleanup!!

Let me know if you do want to take another pass based on my comments. I'm also happy to merge it as-is, just give me the go-ahead :)

@jkosh44
Copy link
Contributor Author

jkosh44 commented Jan 9, 2026

Let me know if you do want to take another pass based on my comments.

I'll take another pass, thanks for the review!

@jkosh44 jkosh44 force-pushed the task-monitor-docs branch from 3837805 to 208f168 Compare January 9, 2026 01:33
@jlizen
Copy link
Member

jlizen commented Jan 9, 2026

Thanks for the contribution ♥️
Will get it rolled out as part of #53

@jlizen jlizen merged commit ed96f0f into tokio-rs:main Jan 9, 2026
7 checks passed
@jkosh44 jkosh44 deleted the task-monitor-docs branch January 9, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants