task: fix task module feature flags #7891
Open
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiapitossi
commented
Feb 6, 2026
| } | ||
|
|
||
| cfg_not_rt! { | ||
| pub(crate) mod task; |
Contributor
Author
There was a problem hiding this comment.
Inside the task module only crate coop is available under not_rt
Darksonn
added
T-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, if you look at the Tokio docs the task module it's not under the rt feature flag:
But every public module and struct inside task is under
rtfeature flag (except for coop which is only available for the crate).This also leads to confusion because items that have multiple feature flags don't display the rt flag:
Solution
The solution is to gate the task module under rt feature flag:
Docs
rendered docs