chore: remove thiserror and unused dependencies #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Oct 20, 2025
mladedav
approved these changes
Oct 20, 2025
Collaborator
mladedav
left a comment
mladedav
left a comment
There was a problem hiding this comment.
opentelemetry (which is a dependency) uses thiserror so I don't think there is any real benefit in doing this manually.
But it's true it's not much code so I'm fine with this.
Thanks for the pruning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Was aiming to reduce
synusage in my dependency tree, and noticed a fairly unnecessary use ofthiserrorhere. Also noticed a handful of unused deps, thanks tocargo-shear.Solution
Removal of the unused deps, and replacing
thiserrorwith a manual implementation.