Fix the panic in follows_from
#244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
(note that CI fails due to the lastest commit in the main branch, not my branch) |
mladedav
force-pushed
the
fix/follows-from-panics
branch
from
02f3185 to
35be2a5
Compare
Collaborator
|
Sorry for the close, it is merged into the default branch and you're still the commits' author. I tried to merge it locally to keep the history clean since you split and named the commits well but in the process GitHub found that all the changes have been applied and it closed this automatically. So the code is merged, just the red close status here should be purple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I have been experiencing crashes in my program approximately every 10 minutes due to #183. I have now investigated and found the problem, reproduced it with a test and fixed the panic. Additionally I was missing some documentation on this behaviour.
Solution
This is fixed by instead of
expect-ing the extension data to instead uselet-elseto match and ignore if it is not present. This behaviour also exists in other implementations in the same file.