Open
Conversation
Collaborator
Author
|
I'll have to look closer at what's happening with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There is a potential deadlock described in #250 where we lock
ExtensionsMutwhen entering a span, we letopentelemetryactivate the context, it tries to log throughtracingin that operation which in turn callson_eventin this layer and we try to lockExtensionsMutagain.Solution
We disable
tracingfor the operation in question. We cannot just check whether we already hold the lock because any other layer might try to lock the extensions too.We could alternatively release the lock for the operation but that would mean we need to relock it later and for the duration we either have a clone or we had to take out the
OtelDatafrom the extensions and that could cause its own problems.There's no test to check for this because that would involve making sure that
opentelemetrylogged something in a given operation but I did try the repro mentioned in #250 and this seems to have fixed that.