Make Non-blocking shutdown timeout configurable #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amberley-Sz
changed the title
|
The changes look good to me, can you open a corresponding PR to the master branch as well? |
Amberley-Sz
force-pushed
the
v0.1.x
branch
3 times, most recently
from
3054ad9 to
43637ce
Compare
New PR on master branch here: #3242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the shutdown timeout for the non-blocking tracing-appender to be configurable, and added integration tests of the configurable timeout.
Motivation
Found a solution to this issue
Solution
Added a
shutdown_timeoutfield in the builder, provided the default timeout to be 1 second but also allow users to custom a timeout through the builder pattern.Can have another PR for master branch if necessary.