chore: fix Rust 1.85.0 lints and errors #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hds
force-pushed
the
hds/rust-clippy-1.85
branch
2 times, most recently
from
1c74be9 to
2b80ced
Compare
hds
changed the title
hds
force-pushed
the
hds/rust-clippy-1.85
branch
from
2b80ced to
eea9224
Compare
We had some broken link formatting in the `tracing-journald` docs which clippy picked up (the text looked like a link definition, but wasn't meant to be). The incorrect links have now been corrected. They have to link to the `tracing-core` crate because `tracing-journald` doesn't depend on `tracing` directly. Fixes for a broken link in the `tracing-subscriber` main page and correcting the link to `Collect` from `tracing-log` (which also doesn't depend on `tracing` directly) were also included.
hds
force-pushed
the
hds/rust-clippy-1.85
branch
from
eea9224 to
bf08bd7
Compare
davidbarsky
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We had some broken link formatting in the
tracing-journalddocs whichclippy picked up (the text looked like a link definition, but wasn't
meant to be).
Solution
The incorrect links have now been corrected. They have to link to the
tracing-corecrate becausetracing-journalddoesn't depend ontracingdirectly.Fixes for a broken link in the
tracing-subscribermain page andcorrecting the link to
Collectfromtracing-log(which also doesn'tdepend on
tracingdirectly) were also included.