-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use state machine to parse directives #3243
base: v0.1.x
Are you sure you want to change the base?
Conversation
Added
This app sets AFAICT you fixed it and it's nearly free now. |
After this, |
Nice catch, yes! Added that into the first commit. |
Intended to fix #3174. Have not done any benchmarks yet -- suggestions on how best to approach that are welcome.
This is a little bit more code, but IMO maybe slightly more readable?
It's correct enough that it passes the tests, there might be edge cases that aren't covered but those should be easy to solve.