Create fewer backtrace frames when using #[instrument] #3469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at fixing #3453. It does require bumping the
tracing-attributescrate to rust 2024, which then requires bumping the MSRV to 1.85, but this is well within the tracing MSRV policy, which states that only the current stable and the previous 3 versions must be supported.I have only updated the
tracing-attributescrate to 2024. I also haven't updated the README or anything else that might need upgrading. If this looks interesting to you, let me know and I can look into porting the rest as well.Implementation notes
This implements the suggestion from #3453: It stops using
async fnin the generated code to avoid extra entries in the backtrace.The reason why rust 2024 is needed, is because the lifetime rules of 2018 -- otherwise the
impl Futuredid not infer the correct lifetime bounds.One possible downside of this way of implementing it is that does make one of the error messages from the ui test worse. If that is not something that is acceptable, perhaps the codegen can be tweaked further to keep the original
async fnand call that instead of using anasync moveblock.