tracing-appender: fix file deletion on filesystems without creation t… #3471
+74
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imestamps On filesystems where `std::fs::Metadata::created` is unsupported, `RollingFileAppender` falls back to parsing the creation date from the log filename. However, `PrimitiveDateTime::parse` fails with `InsufficientInformation` for daily and weekly rotations because the filename lacks time components. Replace the direct `time::PrimitiveDateTime::parse` call with a `time::parsing::Parsed`-based approach that defaults missing hour to midnight (00:00:00), allowing date-only filenames to be parsed successfully. Fixes: tokio-rs#3470
|
Hey everyone, we’re affected by this issue on AWS EFS (NFSv4.1). In our environment, For reference, the filesystem is mounted as NFSv4.1 (EFS); we have something like: This setup reproduces the issue consistently. It resolves the problem for EFS/NFS environments where Thanks @yhibo for proposing the fix. |
dertin
reviewed
Feb 6, 2026
dertin
approved these changes
Feb 6, 2026
EmilianoQS
approved these changes
Feb 6, 2026
Added unit tests for parsing dates from log filenames with daily, hourly, and minutely rotations. Each test verifies that the correct timestamp is generated from the filename formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3470
Motivation
On filesystems where
std::fs::Metadata::createdis unsupported,RollingFileAppenderfalls back to parsing the creation date from the log filename. However,PrimitiveDateTime::parsefails withInsufficientInformationfor daily and weekly rotations because the filename lacks time components.Solution
Replace the direct
time::PrimitiveDateTime::parsecall with atime::parsing::Parsed-based approach that defaults missing hour to midnight (00:00:00), allowing date-only filenames to be parsed successfully.