Treat partitions as unreachable hosts #193
Open
+123
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning `ErrorKind::ConnectionRefused` for all deliver failures, this commit associates partitions with the same error as a link not being found -> host unreachable. The `ErrorKind` in this commit is Other, pending `ErrorKind::HostUnreachable` stabilization.
brandonpike
force-pushed
the
host_unreachable
branch
from
4b50389 to
a46830f
Compare
Rust 1.83 has dropped and with it comes new error kinds!
brandonpike
force-pushed
the
host_unreachable
branch
from
a46830f to
35637e3
Compare
Rust 1.83 has dropped and with it comes new error kinds!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning
ErrorKind::ConnectionRefusedfor all deliver failures, this commit makes the following differentiations:ErrorKind::HostUnreachable("host unreachable")ErrorKind::HostUnreachable("host unreachable")Rust 1.83 has dropped and with it comes new error kinds. We can classify host unreachable errors with their proper error type now.
This PR also fixes some clippy warnings from 1.83.
Fixes #169