Add peek to TcpStream. #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'll be out for a couple of days so my review will be delayed until later in the week. Adding @LucioFranco if you have availability. I haven't looked yet, but we'll want to ensure #184 fits into whatever is added here. |
Contributor
|
I'm taking a look at this now :) |
- Ensure both peek + poll_peek have docs, and those docs match the tokio ones. - Add a trace point for peek
marcbowes
approved these changes
Jan 28, 2025
Contributor
marcbowes
left a comment
marcbowes
left a comment
There was a problem hiding this comment.
Thanks for the contribution and comprehensive tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our codebase is using the
peekfunctions that Turmoil does not model. It seemed easy to add so here's an attempt to add them for TCP.