Change Builder to accept an rng seed
#246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of a `Box<dyn RngCore>`. This change has two benefits: * It removes turmoil's public dependency on the `rand` crate, making it easier to upgrade that crate in the future. * It cleans up the `Builder` API by not having two separate `build*` methods. This is a breaking change, though the hope is that it reduces the need for future breaking changes.
Contributor
Author
|
CI fails because it correctly detects the breaking change. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of a
Box<dyn RngCore>.This change has two benefits:
randcrate, making it easier to upgrade that crate in the future.BuilderAPI by not having two separatebuild*methods.This is a breaking change, though the hope is that it reduces the need for future breaking changes. For example, #215 would not be a breaking change with this new API.