Let network faults affect in-flight messages #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcches
reviewed
Dec 8, 2025
Contributor
mcches
left a comment
mcches
left a comment
There was a problem hiding this comment.
Thanks for doing this. A couple minor comments.
Contributor
|
Also note that barriers landed in a recent PR, which is worth checking out. |
When injecting network faults (partition, hold) into a link, also update the state of messages already in the `sent` queue, instead of having the fault only affect messages that are enqueued in the future. This changes enables writing tests in which one observes the contents of a link to find the point in time in which a given message is sent, to then prevent that message from getting delivered.
teskje
force-pushed
the
faults-affect-sent
branch
from
76f2117 to
e8d5f2a
Compare
mcches
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When injecting network faults (partition, hold) into a link, also update the state of messages already in the
sentqueue, instead of having the fault only affect messages that are enqueued in the future.This changes enables writing tests in which one observes the contents of a link to find the point in time in which a given message is sent, to then prevent that message from getting delivered.
Closes #251