clarify paragraph in "On using std::sync::Mutex and tokio::sync::Mutex"
#836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utex`" Regarding to how the synchronous and asynchronous `Mutex` behave with the executor.
conectado
changed the title
std::sync::Mutex and tokio::sync::Mutexstd::sync::Mutex and tokio::sync::Mutex"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way that this paragraph is written right now it makes it seem that
tokio::sync::Mutex::lockwill block the executor even if the function isasync.As clarified here, this is not the case and the intention of the paragraph is to mention, instead, that this kind of mutex isn't more performant.
Personally, this paragraph has confused me on this behavior in the past. I'm not sure if the wording I used is the best to capture the original intention but I'd like if it can be updated.
Thanks!